Fix for packet source unit test #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkerzendorf
reviewed
Jan 21, 2020
wkerzendorf
reviewed
Jan 21, 2020
| bb = BlackBodySimpleSource(2508) | ||
| #ref_df = pd.read_hdf('test_bb_sampling.h5') | ||
| if pytest.config.getvalue("--generate-reference"): | ||
| ref_bb = pd.read_hdf(packet_unit_test_fpath, key='/blackbody') | ||
| ref_bb.to_hdf(tardis_ref_data, key='/packet_unittest/blackbody', |
There was a problem hiding this comment.
Suggested change
| ref_bb.to_hdf(tardis_ref_data, key='/packet_unittest/blackbody', | |
| ref_bb.to_hdf(tardis_ref_data, key='/packet_unit_test/blackbody', |
There was a problem hiding this comment.
I think Marc followed the convention and named packet_unittest as previous group called plasma_unittest.
wkerzendorf
reviewed
Jan 21, 2020
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* Initial commit * Suggested name change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: after running tests with
--generate-referenceflag the/packet_unittestgroup from the HDF5 five is missing.Solution:
packet_unittestdata is stored in a separated HDF5 file (see tardis-sn/tardis-refdata#25) and then stored inunit_test_data.h5when--generate-referenceis called.